RFR: 8288047: Accelerate Poly1305 on x86_64 using AVX512 instructions [v5]

vpaprotsk duke at openjdk.org
Fri Oct 28 21:06:19 UTC 2022


On Wed, 26 Oct 2022 15:47:28 GMT, vpaprotsk <duke at openjdk.org> wrote:

>> src/hotspot/cpu/x86/macroAssembler_x86_poly.cpp line 806:
>> 
>>> 804:   evmovdquq(A0, Address(rsp, 64*0), Assembler::AVX_512bit);
>>> 805:   evmovdquq(A0, Address(rsp, 64*1), Assembler::AVX_512bit);
>>> 806:   evmovdquq(A0, Address(rsp, 64*2), Assembler::AVX_512bit);
>> 
>> This is load from stack into A0. Did you intend to store A0 (cleanup) into stack local area here? I think the source and destination are mixed up here.
>
> Wow! Thank you for spotting this

done

-------------

PR: https://git.openjdk.org/jdk/pull/10582


More information about the security-dev mailing list