RFR: 8296072: CertAttrSet::encode and DerEncoder::derEncode should write into DerOutputStream [v3]

Sean Mullan mullan at openjdk.org
Mon Oct 31 18:37:21 UTC 2022


On Mon, 31 Oct 2022 18:26:25 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   same for DerEncoder::derEncode
>>   
>>   only in patch2:
>>   unchanged:
>
> src/java.base/share/classes/sun/security/pkcs10/PKCS10Attributes.java line 96:
> 
>> 94:      * @exception IOException on encoding errors.
>> 95:      */
>> 96:     public void encode(DerOutputStream out) throws IOException {
> 
> Add `@Override`.

I think you are missing `@Override` on some of the other `encode` and `derEncode` methods.

-------------

PR: https://git.openjdk.org/jdk/pull/10906


More information about the security-dev mailing list