RFR: JDK-8291509 Minor cleanup could be done in sun.security [v4]

Weijun Wang weijun at openjdk.org
Thu Sep 1 02:54:31 UTC 2022


On Wed, 31 Aug 2022 04:22:15 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/pkcs12/MacData.java line 47:
>> 
>>> 45: 
>>> 46:     private String digestAlgorithmName;
>>> 47:     private AlgorithmParameters digestAlgorithmParams;
>> 
>> Yes, this field is not used now. But one day we might see one that has parameters. I'd rather keep them and maybe fix `getEncoded` by then.
>
> I put the field back.

There are altogether 3 places where this field was assigned. Make sure to add back all of them.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list