RFR: 8293088: Fix compilation with the new Visual Studio preprocessor
Phil Race
prr at openjdk.org
Thu Sep 1 16:22:19 UTC 2022
On Tue, 30 Aug 2022 12:08:09 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> Fix compilation with Zc:preprocessor enabled.
>
> The flag itself will be enabled in [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283); I enabled the flag using instructions found in Magnus's comment on that issue.
>
> Windows 10 SDK version 2104 (10.0.20348.0) is required for successful compilation. Compilation fails with a warning (treated as error by default) with older versions of Windows 10 SDK.
>
> I verified that the compilation completes successfully with this patch, both in debug and in release mode, both with and without Zc:preprocessor.
Fixing the compilation is one thing. But did you verify that it actually works as intended ?
-------------
PR: https://git.openjdk.org/jdk/pull/10080
More information about the security-dev
mailing list