RFR: 5066842: PKCS8EncodedKeySpec needs getAlgorithm method [v2]

Weijun Wang weijun at openjdk.org
Fri Sep 2 00:01:47 UTC 2022


On Thu, 1 Sep 2022 23:28:32 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fine tune spec
>
> src/java.base/share/classes/java/security/spec/EncodedKeySpec.java line 109:
> 
>> 107:      * If this object is created with {@link #EncodedKeySpec(byte[])}, this method in
>> 108:      * this base class returns {@code null}. A child class may parse the content of the encoded
>> 109:      * key and return its algorithm name if one can be recovered.
> 
> Personally I think it sounds better to say "key and return its algorithm name if it can be determined.

OK.

-------------

PR: https://git.openjdk.org/jdk/pull/10131



More information about the security-dev mailing list