RFR: JDK-8291509 Minor cleanup could be done in sun.security [v6]

Mark Powers mpowers at openjdk.org
Tue Sep 13 17:18:11 UTC 2022


On Tue, 6 Sep 2022 22:48:00 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Mark Powers has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   white space
>
> src/java.base/share/classes/sun/security/ssl/CertificateMessage.java line 610:
> 
>> 608:             X509TrustManager tm = chc.sslContext.getX509TrustManager();
>> 609: 
>> 610:             // Find the key exchange algorithm used.
> 
> Not a native English speaker, but I find "find out" better.

You are right. Use "find" for objects, e.g. "I have to find my car". Use "find out" for information, e.g. "Find out when the party starts".

> src/java.base/share/classes/sun/security/ssl/DTLSRecord.java line 40:
> 
>> 38:      * The size of the header plus the max IV length
>> 39:      */
>> 40:     int    headerPlusMaxIVSize =
> 
> Maybe join the next line? Same below.

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/9972


More information about the security-dev mailing list