RFR: JDK-8291509 Minor cleanup could be done in sun.security [v7]

Mark Powers mpowers at openjdk.org
Wed Sep 14 13:53:00 UTC 2022


On Wed, 14 Sep 2022 03:14:29 GMT, Mark Powers <mpowers at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/SSLCipher.java line 70:
>> 
>>> 68:     @SuppressWarnings({"unchecked", "rawtypes"})
>>> 69:     B_NULL("NULL", NULL_CIPHER, 0, 0, 0, 0, true, true,
>>> 70:             new Map.Entry[] {
>> 
>> It looks cleaner to me if `new Map.Entry[] {` is put at the end of the previous line. Otherwise, the indentation seems growing backwards. Same for line 80 and all below.
>
> I did as you suggested and did a bit more with the indentation.

I reworked it again. Take a look.

-------------

PR: https://git.openjdk.org/jdk/pull/9972



More information about the security-dev mailing list