RFR: 8293779: redundant checking in AESCrypt.makeSessionKey() method [v2]

Xue-Lei Andrew Fan xuelei at openjdk.org
Wed Sep 14 16:03:50 UTC 2022


On Wed, 14 Sep 2022 13:25:41 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Xue-Lei Andrew Fan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove unused throws in comment
>>  - remove unused throws
>
> src/java.base/share/classes/com/sun/crypto/provider/AESCrypt.java line 604:
> 
>> 602:      * @exception InvalidKeyException  If the key is invalid.
>> 603:      */
>> 604:     private void makeSessionKey(byte[] k) throws InvalidKeyException {
> 
> Can it still throw InvalidKeyException?

Good catch.  The throws is no longer needed.

-------------

PR: https://git.openjdk.org/jdk/pull/10263


More information about the security-dev mailing list