RFR: 8293779: redundant checking in AESCrypt.makeSessionKey() method [v3]

Xue-Lei Andrew Fan xuelei at openjdk.org
Wed Sep 14 18:13:40 UTC 2022


> Hi,
> 
> Please review this simple code cleanup.
> 
> The following checking for key in the makeSessionKey() method is redundant as it the same checking has been performance before calling the method.
> 
> 
>         if (k == null) {
>             throw new InvalidKeyException("Empty key");
>         }
>         if (!isKeySizeValid(k.length)) {
>              throw new InvalidKeyException("Invalid AES key length: " +
>                                            k.length + " bytes");
>         }
> 
> 
> No new regression test, simple cleanup.
> 
> Thanks,
> Xuelei

Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:

  check only if necessary

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10263/files
  - new: https://git.openjdk.org/jdk/pull/10263/files/d915ca1b..af61f2ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10263&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10263&range=01-02

  Stats: 10 lines in 1 file changed: 6 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/10263.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10263/head:pull/10263

PR: https://git.openjdk.org/jdk/pull/10263



More information about the security-dev mailing list