RFR: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation

Valerie Peng valeriep at openjdk.org
Wed Sep 14 18:43:44 UTC 2022


On Wed, 14 Sep 2022 17:03:41 GMT, zzambers <duke at openjdk.org> wrote:

> During testing I have found messages such as this are printed to stdout:
> 
> sun.security.pkcs11.P11PSSSignature at 6e1567f1: Calling C_SignUpdate
> 
> 
> **Problem:**
> Problem is in P11PSSSignature.engineUpdate method [1], which unconditionally prints some debug information to stdout. Other prints in that class are conditional based on value of DEBUG field.
> 
> **Solution:**
> I have made fix to make these conditional based on value of DEBUG field. As it only affects debug messages, there is no test added.
> 
> **Testing:**
> Passed jdk_security locally with my fix.
> 
> [1] https://github.com/openjdk/jdk/blob/211fab8d361822bbd1a34a88626853bf4a029af5/src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PSSSignature.java#L578

Thanks for catching and fixing it.

-------------

Marked as reviewed by valeriep (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10270



More information about the security-dev mailing list