RFR: JDK-8293808: mscapi destroyKeyContainer enhance KeyStoreException: Access is denied exception [v2]

Weijun Wang weijun at openjdk.org
Fri Sep 16 13:37:46 UTC 2022


On Fri, 16 Sep 2022 07:43:00 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Currently we see on various Windows machines the following exception :
>> https://bugs.openjdk.org/browse/JDK-8293097
>> 
>> java.security.KeyStoreException: Access is denied.
>> 
>> This should probably be enhanced a bit so that the exception tell us more about what went wrong exactly.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add errcode output to ThrowException

Changes requested by weijun (Reviewer).

src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp line 165:

> 163:         strcpy(szMessage, "Unknown error");
> 164:     }
> 165:     snprintf(szMessage2, sizeof(szMessage2), "error %lu, %s", msg, dwError, szMessage);

`msg` is from nowhere.

-------------

PR: https://git.openjdk.org/jdk/pull/10280



More information about the security-dev mailing list