RFR: 8254711: Add java.security.Provider.getService JFR Event

Jaikiran Pai jpai at openjdk.org
Mon Sep 19 13:38:07 UTC 2022


On Wed, 27 Jul 2022 13:14:39 GMT, Sean Coffey <coffeys at openjdk.org> wrote:

> Add a JFR Event for `java.security.Provider.getService(String type, String algorithm)` calls.

The failures reported in the GitHub Actions job look related to this change - `jdk.jfr.event.metadata.TestDefaultConfigurations` test appears to be failing:


java.lang.Exception: Setting 'threshold' in event 'jdk.SecurityProviderService' was not configured in the configuration 'default'
Setting 'threshold' in event 'jdk.SecurityProviderService' was not configured in the configuration 'profile'

	at jdk.jfr.event.metadata.TestDefaultConfigurations.throwExceptionWithErrors(TestDefaultConfigurations.java:115)
	at jdk.jfr.event.metadata.TestDefaultConfigurations.main(TestDefaultConfigurations.java:76)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:125)
	at java.base/java.lang.Thread.run(Thread.java:1589)

JavaTest Message: Test threw exception: java.lang.Exception: Setting 'threshold' in event 'jdk.SecurityProviderService' was not configured in the configuration 'default'
Setting 'threshold' in event 'jdk.SecurityProviderService' was not configured in the configuration 'profile'

src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/JDKEvents.java line 32:

> 30: 
> 31: import jdk.jfr.Event;
> 32: import jdk.jfr.events.*;

Hello Sean, rest of the changes look fine to me, except this one. Was this an intentional change to use `*` import instead of the explicit ones?

-------------

PR: https://git.openjdk.org/jdk/pull/9657


More information about the security-dev mailing list