RFR: JDK-8305406: Add @spec tags in java.base/java.* (part 2)
Daniel Jeliński
djelinski at openjdk.org
Wed Apr 5 15:31:08 UTC 2023
On Tue, 4 Apr 2023 19:46:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review a doc update to add `@spec` into the rest of the files in `java.base` (compared to those in [JDK-8305206](https://bugs.openjdk.org/browse/JDK-8305206) PR #13248)
Marked as reviewed by djelinski (Reviewer).
src/java.base/share/classes/java/security/Key.java line 91:
> 89: * @spec serialization/index.html Java Object Serialization Specification
> 90: * @spec https://www.rfc-editor.org/info/rfc5280
> 91: * RFC 5280: Internet X.509 Public Key Infrastructure Certificate
any reason why you indented this comment with 8 spaces? All others are indented with 6
src/java.base/share/classes/java/security/cert/X509Certificate.java line 630:
> 628: * UTF-8 String Representation of Distinguished Names
> 629: * @spec https://www.rfc-editor.org/info/rfc822
> 630: * RFC 822:: STANDARD FOR THE FORMAT OF ARPA INTERNET TEXT MESSAGES
Suggestion:
* RFC 822: STANDARD FOR THE FORMAT OF ARPA INTERNET TEXT MESSAGES
-------------
PR Review: https://git.openjdk.org/jdk/pull/13336#pullrequestreview-1373161162
PR Review Comment: https://git.openjdk.org/jdk/pull/13336#discussion_r1158675317
PR Review Comment: https://git.openjdk.org/jdk/pull/13336#discussion_r1158672811
More information about the security-dev
mailing list