RFR: 8305858: Resolve multiple definition of 'handleSocketError' when statically linking with JDK native libraries

Wed Apr 12 06:32:40 UTC 2023

On Wed, 12 Apr 2023 03:20:47 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

> Rename 'handleSocketError' to 'sctpHandleSocketError' in libsctp. This resolves the related duplicate symbol failures when both libnio and libsctp are statically linked with the launcher.
> 
> Remove #include "nio_util.h" from SctpChannelImpl.c and SctpNet.c. Looks like that's only needed for handleSocketError() declaration. Declare sctpHandleSocketError() in Sctp.h.
> 
> (Sorry about the earlier RFR/Withdrawn noise.)

This looks okay but it makes me wonder about loadSocketExtensionFuncs. Maybe we should remove that from Sctp.h and change loadSocketExtensionFuncs in SctpNet.c to be static.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13438#issuecomment-1504733524