RFR: 8297878: KEM: Implementation

Weijun Wang weijun at openjdk.org
Wed Apr 12 18:35:37 UTC 2023


On Wed, 12 Apr 2023 14:10:16 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> The KEM API and DHKEM impl. Note that this PR uses new methods in https://github.com/openjdk/jdk/pull/13250.
>
> src/java.base/share/classes/javax/crypto/KEMSpi.java line 107:
> 
>> 105:      * @see KEM.Encapsulator
>> 106:      */
>> 107:     interface EncapsulatorSpi {
> 
> Is it really necessary to define a EncapsulatorSpi?  It looks like an internal implementation for KEMSpi service, rather than a public individual interface that EncapsulatorSpi.getInstance() could be used.

Not exactly sure what you want. Security providers need to implement it and the `KEM` class uses it. Unlike other `AbcSpi` classes, it will not be created with a `getInstance` method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1164503858



More information about the security-dev mailing list