RFR: 8297878: KEM: Implementation [v10]

[Weijun Wang]

On Thu, 27 Apr 2023 12:54:03 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   no more pk/sk, AIOOBE to IOOBE
>
> src/java.base/share/classes/javax/crypto/KEM.java line 90:
> 
>> 88: 
>> 89:     /**
>> 90:      * This class specifies the returned value of the encapsulate method of
> 
> s/returned/return/

OK.

> src/java.base/share/classes/javax/crypto/KEM.java line 100:
> 
>> 98:      * @see Encapsulator#encapsulate(int, int, String)
>> 99:      */
>> 100:     public static final class Encapsulated {
> 
> Missing `@since 21`.

I thought there is no need to add this to an inner class. I'll ask Joe for advice.

> src/java.base/share/classes/javax/crypto/KEM.java line 148:
> 
>> 146:          * Returns the optional parameters in a byte array.
>> 147:          *
>> 148:          * @return the optional parameters in a byte array. A new copy of the
> 
> Should probably say "the optional parameters in a byte array or `null` if not specified`.

OK.

> src/java.base/share/classes/javax/crypto/KEM.java line 239:
> 
>> 237:          * Returns the size of the shared secret.
>> 238:          * <p>
>> 239:          * This method can be called to find out the length of the share secret
> 
> s/share/shared/

Oops.

> src/java.base/share/classes/javax/crypto/KEM.java line 362:
> 
>> 360:          * Returns the size of the shared secret.
>> 361:          * <p>
>> 362:          * This method can be called to find out the length of the share secret
> 
> s/share/shared/

Oops.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179263143
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179262971
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179262197
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179261989
PR Review Comment: https://git.openjdk.org/jdk/pull/13256#discussion_r1179261856