RFR: 8313206: PKCS11 tests silently skip execution [v3]

[Sibabrata Sahoo]

On Thu, 3 Aug 2023 09:46:48 GMT, Sibabrata Sahoo <ssahoo at openjdk.org> wrote:

>> Rajan Halade has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8313206: revert skipTest update to address with new bug
>
> test/jdk/sun/security/pkcs11/PKCS11Test.java line 973:
> 
>> 971:         return r;
>> 972:     }
>> 973: 
> 
> I am not sure if 'NO_DEFAULT' expected to be true in setCommonSystemProps() Line:977 or it need to be explicitly reset by each Test where testDefault() expected to be executed,
> System.setProperty("NO_DEFAULT", "true"); 
> 
> If it is supposed to be true then the testDefault() will always get skipped with the following condition,
> Line:270-273 is will return before proceeding to test the default provider,
> if ("true".equals(System.getProperty("NO_DEFAULT"))) {
>              System.out.println("Skip default provider as test configured with NO_DEFAULT");
>              return;
> }

I see few Tests use "-DNO_DEIMOS=true -DNO_DEFAULT=true" in @run tag when they don't want the specific provider to be used. In that case Line:977 System.setProperty("NO_DEFAULT", "true"); is expected to be "false"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15125#discussion_r1282974501