RFR: 8311170: Simplify and modernize equals and hashCode in security area [v12]

Fri Aug 4 09:38:38 UTC 2023

On Thu, 3 Aug 2023 22:49:46 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback
>
> src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java line 272:
> 
>> 270:             }
>> 271: 
>> 272:             if (!(that.getAlgorithm().equalsIgnoreCase(getAlgorithm()))){
> 
> why removing the space before the "{"?

It surprises me as much as it probably surprises you. Looks like a sloppy merge (821f617ffae) on my part.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14738#discussion_r1284208096