RFR: 8312259: StatusResponseManager unused code clean up [v4]
Jamil Nimeh
jnimeh at openjdk.org
Mon Aug 7 15:38:30 UTC 2023
On Mon, 31 Jul 2023 19:09:53 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:
>> Hi,
>>
>> May I have the code cleanup update reviewed? With this update, the unused code in StatusResponseManager.java will be removed.
>>
>> Thanks,
>> Xuelei
>
> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>
> remove unintended blank line
The removal of these methods is fine. Many of these were in there to support a different planned approach to populating the SRM's cache, but we went with a simpler approach when it was implemented in JDK 9. If we ever decide to implement a scheduler-based refresh we can always add the methods that we need back.
-------------
Marked as reviewed by jnimeh (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14924#pullrequestreview-1565627903
More information about the security-dev
mailing list