RFR: 8313206: PKCS11 tests silently skip execution [v5]

Sean Mullan mullan at openjdk.org
Tue Aug 8 19:31:37 UTC 2023


On Tue, 8 Aug 2023 17:48:21 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> I have updated PKCS11Test.java to mark test as skipped only when all testDefault, testNSS, and testDeimos tests are skipped. This file also includes new trace messages, code cleanup and format change. Some other test files are updated to mark as skipped as they use TestNG framework to execute.
>> 
>> Enhancement [JDK-8313575](https://bugs.openjdk.org/browse/JDK-8313575) is filed to consider refractor of tests to split these for us to better track the coverage.
>
> Rajan Halade has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8313206-pkcs11skip
>  - Address review comments - 1
>  - Address review comments - 1
>  - 8313206: revert skipTest update to address with new bug
>  - 8313206: update Secmod tests
>  - 8313206: mark skipped only when all three tests are skipped
>  - Merge branch 'master' into 8313206-pkcs11skip
>  - 8313206: add test trace messages
>  - 8313206: PKCS11 tests silently skip execution

Copyrights need to be updated. Otherwise, looks fine.

-------------

Marked as reviewed by mullan (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15125#pullrequestreview-1568007748


More information about the security-dev mailing list