RFR: 8314045: ArithmeticException in GaloisCounterMode [v2]

Liam Miller-Cushon cushon at openjdk.org
Wed Aug 9 23:45:28 UTC 2023


On Wed, 9 Aug 2023 23:09:37 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Check for AEADBadTagException specifically
>
> test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMShortInput.java line 54:
> 
>> 52:             cipher.doFinal(ByteBuffer.allocate(0), ByteBuffer.allocate(0));
>> 53:             throw new AssertionError("GeneralSecurityException expected");
>> 54:         } catch (GeneralSecurityException e) {
> 
> The test should be verifying the exception is AEADBadTagException, not GeneralSecurityException, since that is the issue.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15212#discussion_r1289345612



More information about the security-dev mailing list