RFR: 8314148: Fix variable scope in SunMSCAPI [v2]

Valerie Peng valeriep at openjdk.org
Mon Aug 14 21:45:07 UTC 2023


On Fri, 11 Aug 2023 20:15:59 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this patch that fixes the scope of 2 local variables to make sure they are in scope when they are used.
>> 
>> The patch additionally fixes one `c++11-narrowing` Clang warning by explicitly casting string size (`size_t`) to `DWORD`.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix verify method, reduce variable scope

Looks good. Thanks!

-------------

Marked as reviewed by valeriep (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15242#pullrequestreview-1577695160



More information about the security-dev mailing list