RFR: 8312428: PKCS11 tests fail with NSS 3.91 [v3]

Valerie Peng valeriep at openjdk.org
Tue Aug 15 01:08:11 UTC 2023


On Thu, 10 Aug 2023 19:36:28 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Do you mean throw SkippedException if no digest algorithms are actually tested with Clone functionality testing? Existing NSS impl seems to support clone for non-SHA-3 digest impls.
>
> Yes, test should throw SkippedException when nothing is tested.

I re-factored the test to throw SkippedException when no digest algorithm supports clone functionality.

>> This is just one digest algorithm. To mark the test skipped if none of the algorithms are supported will require different handling.
>
> Yes est should only throw `SkippedEXception` when all algos are skipped.

Re-factored test to throw SkippedException if all algos are skipped.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1294095810
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1294096304



More information about the security-dev mailing list