RFR: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range. [v4]

Valerie Peng valeriep at openjdk.org
Fri Aug 18 01:52:27 UTC 2023


On Thu, 17 Aug 2023 18:33:09 GMT, Ben Perez <duke at openjdk.org> wrote:

>> Fixing the bug as stated would cause compatibility issues. E.g. the `addProvider` function always adds new providers at position 0 and therefore would always throw an error. Instead of changing how the function handles indices, we instead have added this behavior to the function spec.
>
> Ben Perez has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed function spec wording, updated test

test/jdk/java/security/Provider/ChangeProviders.java line 84:

> 82:         }
> 83: 
> 84:         //Ensure that providers inserted at position 0 or > n are placed

nit: this sentence is a bit hard to parse, maybe it's easier to just state that positions out of the [1...n] range is placed at the position n+1?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14925#discussion_r1297904164



More information about the security-dev mailing list