RFR: 8175874: Update Security.insertProviderAt to specify behavior when requested position is out of range. [v6]

Ben Perez duke at openjdk.org
Mon Aug 21 16:23:18 UTC 2023


> Fixing the bug as stated would cause compatibility issues. E.g. the `addProvider` function always adds new providers at position 0 and therefore would always throw an error. Instead of changing how the function handles indices, we instead have added this behavior to the function spec.

Ben Perez has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'openjdk:master' into JDK-8175874
 - Simplified test in ChangeProviders
 - Changed function spec wording, updated test
 - Changed wording in spec
 - Removed implnote and added to function specification instead
 - removed unnecessary newlines
 - added impl note to insertProviderAt

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14925/files
  - new: https://git.openjdk.org/jdk/pull/14925/files/71bb6a6a..1addeebf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14925&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14925&range=04-05

  Stats: 86076 lines in 2329 files changed: 46676 ins; 26440 del; 12960 mod
  Patch: https://git.openjdk.org/jdk/pull/14925.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14925/head:pull/14925

PR: https://git.openjdk.org/jdk/pull/14925



More information about the security-dev mailing list