RFR: 8312428: PKCS11 tests fail with NSS 3.91 [v3]

Valerie Peng valeriep at openjdk.org
Fri Aug 25 19:52:15 UTC 2023


On Wed, 23 Aug 2023 18:21:28 GMT, Rajan Halade <rhalade at openjdk.org> wrote:

>> Valerie Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More review feedbacks
>
> test/jdk/sun/security/pkcs11/Signature/KeyAndParamCheckForPSS.java line 117:
> 
>> 115:                 System.out.println("=> Skip; no PSS support");
>> 116:                 return;
>> 117:             }
> 
> else...Should the test be marked as failed?

Sure, should not happen but good to check  to be sure.

> test/jdk/sun/security/pkcs11/Signature/SignatureTestPSS.java line 117:
> 
>> 115:                 System.out.println("    => Skip; no PSS support");
>> 116:                 return;
>> 117:             }
> 
> Same here, should test fail here?

Sure.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1306088345
PR Review Comment: https://git.openjdk.org/jdk/pull/15217#discussion_r1306090152


More information about the security-dev mailing list