RFR: 8315097: Rename createJavaProcessBuilder [v3]

David Holmes dholmes at openjdk.org
Thu Aug 31 05:48:04 UTC 2023


On Wed, 30 Aug 2023 11:31:20 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

> So you could create a single createJavaProcessBuilder with add an additional parameter boolean addTestOpts e.g.
createJavaProcessBuilder(List command, boolean addTestOpts) { ... }

@msheppar that is actually where we started, and it was then split into two differently named methods to "make it clear" which one included the test opts without having to remember the name of the parameter that the true/false argument was bound to.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15452#issuecomment-1700402301


More information about the security-dev mailing list