RFR: 8315097: Rename createJavaProcessBuilder [v3]

Alan Bateman alanb at openjdk.org
Thu Aug 31 06:51:00 UTC 2023


On Wed, 30 Aug 2023 17:38:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> I wouldn't be opposed to a change that:
> 
> * Keeps the `createJavaProcessBuilder` name
> * Renames `createTestJvm` to `createJavaProcessBuilderPrependTestOpts`
> * Renames `executeTestJvm` to `executeJavaPrependTestOpts`
> * Removes `createTestJava`
> * Removes `executeTestJava`

The good thing with this is that it very explicit at the use-sites where the test opts are prepended. Also moving from "Jvm" to "Java" is probably right as it executes the "java" launcher, the options are a mix of java launcher options (that the VM doesn't know about) and VM options.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15452#issuecomment-1700459277


More information about the security-dev mailing list