RFR: 8318756 Create better internal buffer for AEADs [v3]

Anthony Scarpino ascarpino at openjdk.org
Wed Dec 6 02:52:36 UTC 2023


On Tue, 28 Nov 2023 20:30:22 GMT, Anthony Scarpino <ascarpino at openjdk.org> wrote:

>> test/micro/org/openjdk/bench/javax/crypto/full/BenchBase.java line 122:
>> 
>>> 120:     public void decrypt() throws Exception {
>>> 121:         decryptCipher.init(Cipher.DECRYPT_MODE, ks,
>>> 122:             encryptCipher.getParameters().
>> 
>> Consider using a different method to obtain parameter spec here; the flamegraph suggests that `getParameters` is responsible for up to 20% of the time spent in these benchmarks
>
> Thanks for point that out.  I have decided to leave this as is.  There are optimizations that can be made to `getParameters` that I would like the benchmark to measure.

There was no optimization available for `getParameters` so I saved the parameters from the encryption op and it greatly improved the test performance

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16487#discussion_r1416590644



More information about the security-dev mailing list