RFR: 8265372: Simplify PKCS9Attribute

Ben Perez duke at openjdk.org
Fri Dec 15 20:40:59 UTC 2023


Refactored PKCS9Attribute to use a hash map instead of multiple arrays. The key for the hash map is an `ObjectIdentifier` and the values are a record `AttributeInfo` that stores the information previously contained in the arrays `PKCS9_VALUE_TAGS`, `VALUE_CLASSES`, and `SINGLE_VALUED`. 

It seems as though we should be able to get rid of constants such as `EMAIL_ADDRESS_OID` since they aren't heavily used with the hash map approach, but since the values are public it might cause compatibility issues.

Another question is how to handle `RSA DSI`, `S/MIME`, `Extended-certificate`, and `Issuer Serial Number` OIDs. The prior version threw an error but in this refactor they are treated as an "unknown OID" and only throw a debug warning. This was addressed in https://bugs.openjdk.org/browse/JDK-8011867 but prior to this refactor the aforementioned OIDs were treated differently than unknown OIDs.

-------------

Commit messages:
 - refactored PKCSAttribute to use a hash map instead of multiple arrays

Changes: https://git.openjdk.org/jdk/pull/17132/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17132&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8265372
  Stats: 245 lines in 1 file changed: 39 ins; 110 del; 96 mod
  Patch: https://git.openjdk.org/jdk/pull/17132.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17132/head:pull/17132

PR: https://git.openjdk.org/jdk/pull/17132



More information about the security-dev mailing list