RFR: 8275338: Add JFR events for notable serialization situations [v4]

Jaikiran Pai jpai at openjdk.org
Tue Dec 19 15:34:49 UTC 2023


On Tue, 19 Dec 2023 12:21:05 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Better name for a label, corrected name of removed field.

test/jdk/jdk/jfr/event/io/TestSerializationMisdeclarationEvent.java line 50:

> 48:  * @requires vm.hasJFR
> 49:  * @library /test/lib
> 50:  * @run junit/othervm jdk.jfr.event.io.TestSerializationMisdeclarationEvent

Is the use of "othervm" needed here because of the use of `jdk.jfr.consumer.RecordingStream`? Does `RecordingStream` do JVM wide state changes? I did a quick look at that class but couldn't come to a conclusion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1431578942



More information about the security-dev mailing list