RFR: 8275338: Add JFR events for notable serialization situations [v3]

Roger Riggs rriggs at openjdk.org
Wed Dec 20 14:19:51 UTC 2023


On Wed, 20 Dec 2023 08:29:19 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> You could define them with an Enum but use the ordinal as the value for JFR.
>
> Same remark here about finality as https://github.com/openjdk/jdk/pull/17129#discussion_r1432400888. public statics should be final.

I'd also remove the error codes, the string messages will be pretty stable and the extra surface area of the constants is just maintenance overhead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1432772028



More information about the security-dev mailing list