RFR: 8275338: Add JFR events for notable serialization situations [v10]

Raffaello Giulietti rgiulietti at openjdk.org
Thu Dec 21 22:27:10 UTC 2023


On Thu, 21 Dec 2023 21:24:43 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Corrected @Label of event and of field.
>
> src/java.base/share/classes/java/io/ObjectStreamClass.java line 466:
> 
>> 464: 
>> 465:         if (SerializationMisdeclarationEvent.enabled() && serializable) {
>> 466:             new SerializationMisdeclarationChecker(cl).checkMisdeclarations();
> 
> Is there any benefit to avoiding the allocation and passing the class through the methods as an extra arg?

The allocation has been removed and the event messages have been simplified in the most recent commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17129#discussion_r1434558624



More information about the security-dev mailing list