RFR: 8301443: Clean broken comments from Windows code [v2]

Alexey Ivanov aivanov at openjdk.org
Fri Feb 3 19:37:53 UTC 2023


On Fri, 3 Feb 2023 15:18:27 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several comments are technically broken in Windows code, this change cleans up the broken comments that managed to slip past reviewers during Integration
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into comments
>  - Partial Revert
>  - sspi.cpp
>  - Comments

Except for the change in `sspi.cpp`, it looks good to me.

src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 31:

> 29: // This library can be built directly with the following command:
> 30: //   cl -I %OPENJDK%\src\java.security.jgss\share\native\libj2gss\ sspi.cpp
> 31: //      -link -dll -out:sspi_bridge.dll

I think the backslash `` should remain there: it's a command line and `` is used to wrap the long line.

-------------

Changes requested by aivanov (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12305



More information about the security-dev mailing list