RFR: 8300259: Add test coverage for processing of pending block files in signed JARs [v2]

Weijun Wang weijun at openjdk.org
Mon Feb 6 15:47:52 UTC 2023


On Tue, 17 Jan 2023 18:54:13 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

>> This PR adds test coverage for pending block files in signed JAR files
>> 
>> A signed JAR has pending block files if the block file [RSA, DSA, EC] comes before the corresponding signature file [SF] in the JAR. 
>> 
>> JarVerifier.processEntry supports processing of such pending block files, but this code path does not seem to be exercised by current test.
>> 
>> The new test PendingBlocksJar checks that signed JARs  with pending blocks are processed correctly, both for the valid and invalid cases.
>
> Eirik Bjorsnos has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Make it more clear in the @summary tag that it is the block file that is pending, not the signature file
>  - Renamed test from PendingBlocksJar to more descriptive SignedJarPendingBlock

Marked as reviewed by weijun (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12009



More information about the security-dev mailing list