RFR: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos [v2]

Claes Redestad redestad at openjdk.org
Mon Feb 6 15:55:52 UTC 2023


On Mon, 6 Feb 2023 15:14:37 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Spelling fix in test data for non-ascii latin1 string
>
> test/jdk/java/util/zip/ZipFile/TestZipFileEncodings.java line 126:
> 
>> 124:         // latin1, but not ASCII
>> 125:         String entryName = "smörgårdsbord";
>> 126: 
> 
> @cl4es Are we ok with non-ASCII in source files? I'd hate to escape this ;-)

As long as the file is UTF-8 encoded then I think it should be fine. Thanks for fixing the spelling before I could remark on it! :D

-------------

PR: https://git.openjdk.org/jdk/pull/12290



More information about the security-dev mailing list