RFR: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos [v2]

Eirik Bjorsnos duke at openjdk.org
Mon Feb 6 16:14:17 UTC 2023


On Mon, 6 Feb 2023 15:56:09 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Spelling fix in test data for non-ascii latin1 string
>
> test/jdk/java/util/zip/ZipFile/InvalidBytesInEntryNameOrComment.java line 153:
> 
>> 151:         // Need to skip past the length of the name and extra fields
>> 152:         int nlen = buffer.getShort(off + NLEN);
>> 153:         int elen = buffer.getShort(off + NLEN);
> 
> Is this supposed to say `ELEN`?

Indeed, good catch! Must have lucked out on the comment be longer than the name :-)

-------------

PR: https://git.openjdk.org/jdk/pull/12290



More information about the security-dev mailing list