RFR: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos [v4]

Claes Redestad redestad at openjdk.org
Wed Feb 8 12:05:44 UTC 2023


On Wed, 8 Feb 2023 11:57:16 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> > > Seems there's a possible real test failure lurking here, might be intermittent since it only showed on one platform:
> > 
> > 
> > Did you get this from GHA somehow? Do you happen to know the platform, timezone and encoding used?
> 
> Yes, clicked through the failing macosx-x64 test suite. Here's a link to the summary which has the failing test logs at the bottom: https://github.com/eirbjo/jdk/actions/runs/4114300244

Seems the failing assert is checking timestamps:

assertEquals((x.getTime() / 2000), y.getTime() / 2000);

... so maybe this is a rare intermittent issue. It's just very suspect though that it happens in the test you're changing.

-------------

PR: https://git.openjdk.org/jdk/pull/12290



More information about the security-dev mailing list