RFR: 8301443: Clean broken comments from Windows code [v5]

Julian Waters jwaters at openjdk.org
Wed Feb 8 14:27:44 UTC 2023


On Wed, 8 Feb 2023 08:23:59 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>>> Alright here you go :) https://bugs.openjdk.org/browse/JDK-8301994
>> 
>> Thank you, @TheShermanTanker.
>> 
>> Do you still want to keep the changes?
>> If it's not too critical, I would rather prefer you revert the changes to `awt_List.cpp`.
>
> No worries, I'm fine with reverting `awt_List.cpp`, I can set my local branch up to avoid a rebase conflict when the commented code does get deleted rather easily
> 
> On the other hand, could I trouble you for a quick review of https://github.com/openjdk/jdk/pull/12405? It's just a constructor from libawt that I happened to overlook in my previous Pull Request on initialization orders. Sorry for the trouble!

Thanks for the review! Are the other changes here ok with you in the meantime?

-------------

PR: https://git.openjdk.org/jdk/pull/12305



More information about the security-dev mailing list