RFR: 8178806: Better exception logging in crypto code

Kevin Driver kdriver at openjdk.org
Thu Feb 9 21:49:47 UTC 2023


On Thu, 9 Feb 2023 21:45:35 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Updated this `template` file to not fail silently on `canUseProvider` check in debug mode to provide additional information to aid in debugging.
>> 
>> See: https://bugs.openjdk.org/browse/JDK-8178806
>
> src/java.base/share/classes/javax/crypto/JceSecurity.java.template line 240:
> 
>> 238:         Exception e = getVerificationResult(p);
>> 239:         if (debug != null) {
>> 240:             if(e != null) {
> 
> line 239 and 240 can be combined into one line?

I thought about this, but logically they are not related... 

I can definitely combine, but I made this choice for readability. What do you think?

-------------

PR: https://git.openjdk.org/jdk/pull/12504



More information about the security-dev mailing list