RFR: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos [v9]
Eirik Bjorsnos
duke at openjdk.org
Tue Feb 14 23:13:45 UTC 2023
On Tue, 14 Feb 2023 11:21:36 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> The message is already validated using `expectedExceptionsMessageRegExp` in the `@Test` annotation.
>>
>> Would you prefer if I use expectThrows instead, or perhaps inline the `BAD_ENTRY_NAME_OR_COMMENT` constant as a literal?
>
> Sorry if this was not clear, we have gone away from using the annotation element `exepectedExceptions` for new and updated tests and have tried to standardize on `assertThrows` and `expectThrows` instead which is the basis for my suggestion.
>
>
> Thank you for your other updates. I will go through them later today
No worries, this makes sense. Updated to expectThrows with assertEquals.
-------------
PR: https://git.openjdk.org/jdk/pull/12290
More information about the security-dev
mailing list