RFR: 8301873: Avoid string decoding in ZipFile.Source.getEntryPos [v12]

Eirik Bjorsnos duke at openjdk.org
Wed Feb 15 11:44:17 UTC 2023


On Wed, 15 Feb 2023 11:32:32 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> The habit of opening resources in a TwR is hard to break, but I guess it's ok for a test like this. I have inlined the method and removed the TwR.
>
>> The habit of opening resources in a TwR is hard to break, but I guess it's ok for a test like this. I have inlined the method and removed the TwR.
> 
> Agree, thanks for addressing the suggestion as it makes the test cleaner given expects/assertThrows should  react to the Exception being thrown by `new ZipFile(...)`

My inlining accidentally made the shouldRejectInvalidComment test the invalid name file. Fixed with last commit.

-------------

PR: https://git.openjdk.org/jdk/pull/12290



More information about the security-dev mailing list