RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v2]

[Matthias Baesken]

On Mon, 30 Jan 2023 12:26:57 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a message is ciphered in multiple, small (< 16 bytes) segments, the result is incorrect.
>> 
>> This is not just a band-aid fix. The issue was taken as a chance to restructure the code. though still complicated, It is now easier to read and (hopefully) understand.
>> 
>> Except for the new jetreg test, the changes are purely s390. There are no side effects on other platforms. Issue-specific tests pass. Other tests are in progress. I will update this PR once they are complete. 
>> 
>> **Reviews and comments are very much appreciated.**
>> 
>> @backwaterred could you please run some "official" s390 tests? Thanks.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8299817: Update copyright

Some small typos found 

nesessary  ->  necessary
sace extended SP ->  save extended SP

Why do you clear memory only in the ASSERT case here ?

src/hotspot/cpu/s390/stubGenerator_s390.cpp

#ifdef ASSERT
    __ clear_mem(Address(Z_SP, (intptr_t)8), resize_len - 8);
#endif

-------------

PR: https://git.openjdk.org/jdk/pull/11967