RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v3]
Lutz Schmidt
lucy at openjdk.org
Thu Feb 16 11:51:59 UTC 2023
> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a message is ciphered in multiple, small (< 16 bytes) segments, the result is incorrect.
>
> This is not just a band-aid fix. The issue was taken as a chance to restructure the code. though still complicated, It is now easier to read and (hopefully) understand.
>
> Except for the new jetreg test, the changes are purely s390. There are no side effects on other platforms. Issue-specific tests pass. Other tests are in progress. I will update this PR once they are complete.
>
> **Reviews and comments are very much appreciated.**
>
> @backwaterred could you please run some "official" s390 tests? Thanks.
Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
829817: fixed typos, removed JIT_TIMER references
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11967/files
- new: https://git.openjdk.org/jdk/pull/11967/files/33722f27..ca40de84
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11967&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11967&range=01-02
Stats: 11 lines in 1 file changed: 0 ins; 8 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/11967.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11967/head:pull/11967
PR: https://git.openjdk.org/jdk/pull/11967
More information about the security-dev
mailing list