RFR: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates

Rajan Halade rhalade at openjdk.org
Thu Feb 16 18:44:29 UTC 2023


On Tue, 14 Feb 2023 12:17:39 GMT, Matthew Donovan <duke at openjdk.org> wrote:

> * Refactored SSLContextTemplate and SSLSocketTemplate to put common code in one base class (SSLContextTemplate)
> * Updated TLS/SSL tests to extend SSLSocketTemplate where possible.
> * Updated SSLEngineTemplate to accommodate changes in SSLContextTemplate. To keep this changeset to a reasonable size, updates to SSLEngine tests will be made under JDK-8301194.

test/jdk/javax/net/ssl/templates/SSLContextTemplate.java line 395:

> 393:         CA_RSA_512( // for DisabledShortRSAKeys test
> 394:                 "RSA",
> 395:                 "-----BEGIN CERTIFICATE-----\n" +

Please add a comment with validity and algorithms similar to other entries in this enum. There are few other entries to update as well.

test/jdk/sun/net/www/protocol/https/HttpsClient/ServerIdentityTest.java line 111:

> 109: 
> 110:     @Override
> 111:     public SSLContext createServerSSLContext() throws Exception {

revert this as well.

-------------

PR: https://git.openjdk.org/jdk/pull/12555



More information about the security-dev mailing list