RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v4]
Amit Kumar
duke at openjdk.org
Wed Feb 22 11:37:07 UTC 2023
On Mon, 20 Feb 2023 12:21:27 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a message is ciphered in multiple, small (< 16 bytes) segments, the result is incorrect.
>>
>> This is not just a band-aid fix. The issue was taken as a chance to restructure the code. though still complicated, It is now easier to read and (hopefully) understand.
>>
>> Except for the new jetreg test, the changes are purely s390. There are no side effects on other platforms. Issue-specific tests pass. Other tests are in progress. I will update this PR once they are complete.
>>
>> **Reviews and comments are very much appreciated.**
>>
>> @backwaterred could you please run some "official" s390 tests? Thanks.
>
> Lutz Schmidt has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - Merge master to resolve copyright conflict
> - 829817: fixed typos, removed JIT_TIMER references
> - 8299817: Update copyright
> - 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
Build and Testing done for tier1 in fastdebug, slowdebug and release build on z15/s390x machine.
LGTM
-------------
Marked as reviewed by offamitkumar at github.com (no known OpenJDK username).
PR: https://git.openjdk.org/jdk/pull/11967
More information about the security-dev
mailing list