Integrated: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
Lutz Schmidt
lucy at openjdk.org
Tue Feb 28 12:55:20 UTC 2023
On Thu, 12 Jan 2023 14:29:34 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a message is ciphered in multiple, small (< 16 bytes) segments, the result is incorrect.
>
> This is not just a band-aid fix. The issue was taken as a chance to restructure the code. though still complicated, It is now easier to read and (hopefully) understand.
>
> Except for the new jetreg test, the changes are purely s390. There are no side effects on other platforms. Issue-specific tests pass. Other tests are in progress. I will update this PR once they are complete.
>
> **Reviews and comments are very much appreciated.**
>
> @backwaterred could you please run some "official" s390 tests? Thanks.
This pull request has now been integrated.
Changeset: e144783e
Author: Lutz Schmidt <lucy at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/e144783eb2d2a4437d0f992c964e34a932bfa54b
Stats: 729 lines in 5 files changed: 519 ins; 64 del; 146 mod
8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls
Reviewed-by: mbaesken, mdoerr
-------------
PR: https://git.openjdk.org/jdk/pull/11967
More information about the security-dev
mailing list