RFR: 8278349: JarSigner javadoc example uses SHA-1

Weijun Wang weijun at openjdk.org
Fri Jan 13 16:43:16 UTC 2023


On Fri, 13 Jan 2023 16:23:13 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> Please review this trivial PR which updates javadoc sample code in jdk.security.jarsigner.JarSigner to use SHA-256, SHA256withRSA instead of the now considered weak algorithms SHA-1, SHA1withDSA.
> 
> The sample code is also updated to use the new snippet syntax.

src/jdk.jartool/share/classes/jdk/security/jarsigner/JarSigner.java line 88:

> 86:  *     signer.sign(in, out);
> 87:  * }
> 88:  * }

You can probably indent the code so that the last 2 lines do not look strange.

-------------

PR: https://git.openjdk.org/jdk/pull/11992



More information about the security-dev mailing list