RFR: 8278349: JarSigner javadoc example uses SHA-1

Sean Mullan mullan at openjdk.org
Fri Jan 13 17:11:20 UTC 2023


On Fri, 13 Jan 2023 16:57:36 GMT, Sean Mullan <mullan at openjdk.org> wrote:

>> src/jdk.jartool/share/classes/jdk/security/jarsigner/JarSigner.java line 88:
>> 
>>> 86:  *     signer.sign(in, out);
>>> 87:  * }
>>> 88:  * }
>> 
>> You can probably indent the code so that the last 2 lines do not look strange.
>
> This might also be a good opportunity to use the new javadoc @snippet tag (see [JEP 413](url)) which I think has some features to handle the indentation in a consistent manner.

Oh, cool, missed that.

Eirik, this issue is currently assigned to @haimaychao, but we can still accept your contribution. Have you or your company signed the OCA?

-------------

PR: https://git.openjdk.org/jdk/pull/11992


More information about the security-dev mailing list