RFR: 8300647: Miscellaneous hashCode improvements in java.base [v2]

Viktor Klang duke at openjdk.org
Thu Jan 19 14:15:40 UTC 2023


On Thu, 19 Jan 2023 13:46:26 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Went through the jdk and found a few more places where `ArraysSupport::vectorizedHashCode` can be used, and a few where adhoc methods could be replaced with a plain call to `java.util.Arrays` equivalents. This patch addresses that.
>> 
>> After this, #12068, and #12077 I think we're reaching the limit of sensible direct use of `AS::vectorizedHashCode`. I've found a few places outside of java.base where `vectorizedHashCode` might be applicable, but none that seem important enough to warrant an export of this method outside of java.base.
>
> Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert ZipFileSystem changes since it's additionally built as a library dependency and can't rely on jdk.internal

src/java.base/unix/classes/java/lang/ProcessEnvironment.java line 415:

> 413:     }
> 414: 
> 415:     // Replace with general purpose method someday

@cl4es Nice work addressing this 16+ year old comment! 👍

-------------

PR: https://git.openjdk.org/jdk/pull/12093



More information about the security-dev mailing list